diff --git a/.chloggen/feat_random-fake-span-durations.yaml b/.chloggen/feat_random-fake-span-durations.yaml new file mode 100755 index 000000000000..9e45507b62ee --- /dev/null +++ b/.chloggen/feat_random-fake-span-durations.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: enhancement + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: telemetrygen + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Exposes the span duration as a command line argument `--span-duration` + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [26991] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [user] diff --git a/cmd/telemetrygen/internal/traces/config.go b/cmd/telemetrygen/internal/traces/config.go index 2ffb44fcc3cb..3d9dedc73361 100644 --- a/cmd/telemetrygen/internal/traces/config.go +++ b/cmd/telemetrygen/internal/traces/config.go @@ -4,6 +4,8 @@ package traces import ( + "time" + "github.com/spf13/pflag" "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen/internal/common" @@ -18,6 +20,7 @@ type Config struct { StatusCode string Batch bool LoadSize int + SpanDuration time.Duration } // Flags registers config flags. @@ -29,4 +32,5 @@ func (c *Config) Flags(fs *pflag.FlagSet) { fs.StringVar(&c.StatusCode, "status-code", "0", "Status code to use for the spans, one of (Unset, Error, Ok) or the equivalent integer (0,1,2)") fs.BoolVar(&c.Batch, "batch", true, "Whether to batch traces") fs.IntVar(&c.LoadSize, "size", 0, "Desired minimum size in MB of string data for each trace generated. This can be used to test traces with large payloads, i.e. when testing the OTLP receiver endpoint max receive size.") + fs.DurationVar(&c.SpanDuration, "span-duration", 123*time.Microsecond, "The duration of each generated span.") } diff --git a/cmd/telemetrygen/internal/traces/traces.go b/cmd/telemetrygen/internal/traces/traces.go index a7e6cb8ce866..9b091ef07e95 100644 --- a/cmd/telemetrygen/internal/traces/traces.go +++ b/cmd/telemetrygen/internal/traces/traces.go @@ -147,6 +147,7 @@ func Run(c *Config, logger *zap.Logger) error { wg: &wg, logger: logger.With(zap.Int("worker", i)), loadSize: c.LoadSize, + spanDuration: c.SpanDuration, } go w.simulateTraces() diff --git a/cmd/telemetrygen/internal/traces/worker.go b/cmd/telemetrygen/internal/traces/worker.go index b5c9794608bb..d23a5f7e14d5 100644 --- a/cmd/telemetrygen/internal/traces/worker.go +++ b/cmd/telemetrygen/internal/traces/worker.go @@ -28,15 +28,14 @@ type worker struct { totalDuration time.Duration // how long to run the test for (overrides `numTraces`) limitPerSecond rate.Limit // how many spans per second to generate wg *sync.WaitGroup // notify when done + loadSize int // desired minimum size in MB of string data for each trace generated + spanDuration time.Duration // duration of generated spans logger *zap.Logger - loadSize int } const ( fakeIP string = "1.2.3.4" - fakeSpanDuration = 123 * time.Microsecond - charactersPerMB = 1024 * 1024 // One character takes up one byte of space, so this number comes from the number of bytes in a megabyte ) @@ -45,12 +44,18 @@ func (w worker) simulateTraces() { limiter := rate.NewLimiter(w.limitPerSecond, 1) var i int for w.running.Load() { + spanStart := time.Now() + spanEnd := spanStart.Add(w.spanDuration) + endTimestampOption := trace.WithTimestamp(spanEnd) + ctx, sp := tracer.Start(context.Background(), "lets-go", trace.WithAttributes( semconv.NetPeerIPKey.String(fakeIP), semconv.PeerServiceKey.String("telemetrygen-server"), ), trace.WithSpanKind(trace.SpanKindClient), + trace.WithTimestamp(spanStart), ) + for j := 0; j < w.loadSize; j++ { sp.SetAttributes(attribute.String(fmt.Sprintf("load-%v", j), string(make([]byte, charactersPerMB)))) } @@ -70,17 +75,17 @@ func (w worker) simulateTraces() { semconv.PeerServiceKey.String("telemetrygen-client"), ), trace.WithSpanKind(trace.SpanKindServer), + trace.WithTimestamp(spanStart), ) if err := limiter.Wait(context.Background()); err != nil { w.logger.Fatal("limiter waited failed, retry", zap.Error(err)) } - opt := trace.WithTimestamp(time.Now().Add(fakeSpanDuration)) child.SetStatus(w.statusCode, "") - child.End(opt) + child.End(endTimestampOption) sp.SetStatus(w.statusCode, "") - sp.End(opt) + sp.End(endTimestampOption) i++ if w.numTraces != 0 { diff --git a/cmd/telemetrygen/internal/traces/worker_test.go b/cmd/telemetrygen/internal/traces/worker_test.go index d6f2ffed0c0d..5d314a1ea2af 100644 --- a/cmd/telemetrygen/internal/traces/worker_test.go +++ b/cmd/telemetrygen/internal/traces/worker_test.go @@ -73,6 +73,38 @@ func TestRateOfSpans(t *testing.T) { assert.True(t, len(syncer.spans) <= 20, "there should have been less than 20 spans, had %d", len(syncer.spans)) } +func TestSpanDuration(t *testing.T) { + // prepare + syncer := &mockSyncer{} + + tracerProvider := sdktrace.NewTracerProvider() + sp := sdktrace.NewSimpleSpanProcessor(syncer) + tracerProvider.RegisterSpanProcessor(sp) + otel.SetTracerProvider(tracerProvider) + + targetDuration := 1 * time.Second + cfg := &Config{ + Config: common.Config{ + Rate: 10, + TotalDuration: time.Second / 2, + WorkerCount: 1, + }, + SpanDuration: targetDuration, + } + + // sanity check + require.Len(t, syncer.spans, 0) + + // test + require.NoError(t, Run(cfg, zap.NewNop())) + + for _, span := range syncer.spans { + startTime, endTime := span.StartTime(), span.EndTime() + spanDuration := endTime.Sub(startTime) + assert.Equal(t, targetDuration, spanDuration) + } +} + func TestUnthrottled(t *testing.T) { // prepare syncer := &mockSyncer{}