-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][exporter/opensearchexporter] use errors.Join instead of go.uber.org/multierr #27908
Merged
mx-psi
merged 3 commits into
open-telemetry:main
from
bagmeg:issues/25121/opensearchexporter
Oct 25, 2023
Merged
[chore][exporter/opensearchexporter] use errors.Join instead of go.uber.org/multierr #27908
mx-psi
merged 3 commits into
open-telemetry:main
from
bagmeg:issues/25121/opensearchexporter
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Oct 23, 2023
bagmeg
changed the title
use errors.Join instead of go.uber.org/multierr
[chore][exporter/opensearchexporter] use errors.Join instead of go.uber.org/multierr
Oct 23, 2023
codeboten
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bagmeg, please resolve the conflict
bagmeg
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
dashpole,
atoulme,
jmacd,
dmitryax,
fatsheep9146,
jpkrohling,
TylerHelmuth,
mx-psi,
bogdandrutu,
evan-bradley,
jsuereth,
arminru,
bryan-aguilar and
tigrannajaryan
as code owners
October 25, 2023 11:02
github-actions
bot
added
cmd/configschema
configschema command
cmd/githubgen
cmd/mdatagen
mdatagen command
labels
Oct 25, 2023
mx-psi
removed request for
jpkrohling,
atoulme,
jsuereth,
bogdandrutu,
dashpole,
jmacd,
tigrannajaryan,
djaglowski,
dmitryax,
arminru,
evan-bradley,
fatsheep9146,
TylerHelmuth,
MovieStoreGuy,
bryan-aguilar and
andrzej-stencel
October 25, 2023 11:15
mx-psi
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Oct 25, 2023
dashpole
approved these changes
Oct 25, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…er.org/multierr (open-telemetry#27908) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…er.org/multierr (open-telemetry#27908) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…er.org/multierr (open-telemetry#27908) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/opensearch
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
use errors.Join instead of go.uber.org/multierr
Link to tracking Issue:
#25121
Testing:
Documentation: