[exporter/googlepubsub] expose Endpoint and Insecure
#29740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Dec 11, 2023
alexvanboxel
force-pushed
the
pubsub-export-add-insecure
branch
from
258d8fe
to
1a74c19
Compare
bryan-aguilar
approved these changes
Dec 12, 2023
Comment on lines
+31
to
+34
| * `endpoint` (Optional): Override the default Pubsub Endpoint, useful when connecting to the PubSub emulator instance | ||
| or switching between [global and regional service endpoints](https://cloud.google.com/pubsub/docs/reference/service_apis_overview#service_endpoints). | ||
| * `insecure` (Optional): allows performing “insecure” SSL connections and transfers, useful when connecting to a local | ||
| emulator instance. Only has effect if Endpoint is not "" |
There was a problem hiding this comment.
I think this README could be improved by listing the default values of all the configuration options. It does not need to be done in this PR but please consider creating a follow up issue to track this.
There was a problem hiding this comment.
I prefer to do this for both my receiver/exporter at the same time. I have a lot of changes lined up and want to do them in small increments.
bryan-aguilar
added
the
ready to merge
expose `Endpoint` and `Insecure` in configuration fixes: open-telemetry#29304
alexvanboxel
force-pushed
the
pubsub-export-add-insecure
branch
from
1a74c19
to
c453bed
Compare
|
I'm trying to keep the branch up-to-date by rebasing, but it goes too fast. BTW, I'm the code-owner (but not a maintainer). |
codeboten
approved these changes
Dec 14, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…try#29740) **Description:** expose `Endpoint` and `Insecure` in configuration **Link to tracking Issue:** open-telemetry#29304 **Testing:** Adapted tests to use the new attributes **Documentation:** Added new attributes to documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
expose
EndpointandInsecurein configurationLink to tracking Issue:
#29304
Testing:
Adapted tests to use the new attributes
Documentation:
Added new attributes to documentation