[processor/remotetap] Fix memory leak on shutdown #32571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Apr 19, 2024
atoulme
approved these changes
Apr 19, 2024
songy23
approved these changes
Apr 19, 2024
codeboten
requested changes
Apr 23, 2024
crobert-1
commented
Apr 23, 2024
codeboten
reviewed
Apr 23, 2024
codeboten
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The remotetap processor holds a map of channels for writing telemetry data to WebSockets when a client connects. The write process works by blocking on a given channel waiting for telemetry data coming through the processor's pipeline, then writing as soon as it comes in. This however can result in a leaked goroutine that blocks forever if data is not received, which is always the case when shutting down.
This fixes the bug by closing and deleting all channels once all client connections have been shutdown gracefully. This fixes the blocking behavior during shutdown.
This change also enables
goleakto help ensure no goroutines are being leaked.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleakcheck.