Update to OTel-Arrow core library v0.25.0 (arrow/v17) #34179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/otelarrow
internal/otelarrow
receiver/otelarrow
labels
…tor-contrib into jmacd/arrow25
…tor-contrib into jmacd/arrow25
jmacd
commented
Jul 22, 2024
mwear
approved these changes
Jul 22, 2024
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
moh-osman3
approved these changes
Jul 23, 2024
1 task
moh-osman3
approved these changes
Jul 23, 2024
|
I will re-open the change with only the testing-related and context-cancellation changes that were triggered here, then I will follow with the OTel-Arrow v0.25.0 update. |
codeboten
pushed a commit
that referenced
this pull request
Jul 26, 2024
**Description:** Several test flakes were identified in #34179. This improves the tests and adds one new test. Adds one new context-canceled return path, fixing a potential goroutine leak covered by new testing. **Link to tracking Issue:** Fixes open-telemetry/otel-arrow#237 **Testing:** - For the test change in `receiver/otelarrowreceiver/internal/arrow/arrow_test.go` note that the test now allows out-of-order responses, which is explicitly a feature. Out-of-order responses may have resulted from performance changes in Arrow v17. - For the context handling in `receiver/otelarrowreceiver/internal/arrow/arrow.go` this is needed to satisfy the HalfOpen test introduced here. A comment in the code explains how previously gRPC stream resources could leak - The ` TestOTelArrowShutdown` test improves readability. It had been using a test helper designed originally for the OTLP (non-streaming) test, which made it convoluted here. A sync.Once has been eliminated. - The new test `TestOTelArrowHalfOpenShutdown` exercises the "adversarial" condition where a client never calls `Recv()` on their stream handle. The new context handling is required to pass the test w/o goroutine leaks. --------- Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This is a routine update following #33567. Includes Arrow v17. Note that the introduction of Arrow v17 is not directly responsible for the minor changes needed to continue passing tests. It appears to be a runtime-behavioral change that triggered existing test flakes and deficiencies. Adds a context.Done() branch in
replyToCaller()to ensure that the receiver does not leak resources as explained in open-telemetry/otel-arrow#237.Link to tracking Issue: #33567
Testing: Test flakes fixed, new test introduced. Fixes open-telemetry/otel-arrow#237.