[exporter/datadog] Upgrade exporter.datadogexporter.UseLogsAgentExporter feature flag to beta
#34420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change and we should list it in the changelog. Do we intend to provide this functionality in the future? Or is this just not going to be supported? |
I don't think there's a corresponding feature/config option in the logs agent, so we were going to leave it unless someone wants to request it as a feature. I believe |
mx-psi
reviewed
Aug 7, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
|
On hold until 0.108 release as discussed offline |
mx-psi
pushed a commit
that referenced
this pull request
Aug 8, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Deprecates `logs::dump_payloads` because this config option is invalid with the Datadog Agent logs pipeline which will be enabled by default in the following release. This PR will be included in v0.107.0 and #34420 will be included in v0.108.0. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> The log appears as follows: ``` 2024-08-07T14:49:10.514-0400 warn datadogexporter@v0.106.1/config.go:462 logs::dump_payloads is deprecated and will raise an error if set when the Datadog Agent logs pipeline is enabled by default in collector version v0.108.0 {"kind": "exporter", "data_type": "logs", "name": "datadog"} ``` **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
|
@liustanley can you fix the merge conflict? |
mx-psi
approved these changes
Aug 14, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Deprecates `logs::dump_payloads` because this config option is invalid with the Datadog Agent logs pipeline which will be enabled by default in the following release. This PR will be included in v0.107.0 and open-telemetry#34420 will be included in v0.108.0. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> The log appears as follows: ``` 2024-08-07T14:49:10.514-0400 warn datadogexporter@v0.106.1/config.go:462 logs::dump_payloads is deprecated and will raise an error if set when the Datadog Agent logs pipeline is enabled by default in collector version v0.108.0 {"kind": "exporter", "data_type": "logs", "name": "datadog"} ``` **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…rter` feature flag to beta (open-telemetry#34420) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Use Datadog Agent logs pipeline by default for exporting logs to Datadog. Upgrades `exporter.datadogexporter.UseLogsAgentExporter` feature flag to beta. Note: if users have `logs::dump_payloads` enabled in their config after upgrading, an error will be raised because this config option cannot be used with the logs agent exporter: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/f1aadc6c9c5d117eb61898cd2f1969a279a7f80e/exporter/datadogexporter/config.go#L658 **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#34366 and introduces general performance improvements. **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use Datadog Agent logs pipeline by default for exporting logs to Datadog. Upgrades
exporter.datadogexporter.UseLogsAgentExporterfeature flag to beta.Note: if users have
logs::dump_payloadsenabled in their config after upgrading, an error will be raised because this config option cannot be used with the logs agent exporter:opentelemetry-collector-contrib/exporter/datadogexporter/config.go
Line 658 in f1aadc6
Link to tracking Issue:
Fixes #34366 and introduces general performance improvements.
Testing:
Documentation: