Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Drop cumulative temporality histogram and exponential histogram #35442

Merged

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Sep 26, 2024

Description:

Drop histogram and exponential histogram with cumulative temporality as they are not supported by Elasticsearch

Link to tracking Issue:

Testing:

Documentation:

@carsonip carsonip changed the title [exporter/elasticsearch] Drop cumulative histogram and exponential histogram [exporter/elasticsearch] Drop non-delta temporality histogram and exponential histogram Sep 26, 2024
@carsonip carsonip marked this pull request as ready for review September 26, 2024 21:30
@carsonip carsonip requested a review from a team as a code owner September 26, 2024 21:30
@carsonip carsonip changed the title [exporter/elasticsearch] Drop non-delta temporality histogram and exponential histogram [exporter/elasticsearch] Drop cumulative temporality histogram and exponential histogram Sep 26, 2024
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments!

exporter/elasticsearchexporter/exporter.go Outdated Show resolved Hide resolved
exporter/elasticsearchexporter/exporter.go Outdated Show resolved Hide resolved
carsonip and others added 4 commits September 27, 2024 12:48
…ential-histogram.yaml

Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
@andrzej-stencel andrzej-stencel merged commit 8d663ce into open-telemetry:main Sep 30, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 30, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…ponential histogram (open-telemetry#35442)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Drop histogram and exponential histogram with cumulative temporality as
they are not supported by Elasticsearch

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants