Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Log and drop invalid metrics instead of returning error to avoid upstream retries #35740

Merged

Conversation

carsonip
Copy link
Contributor

Description

Log metrics validation error instead of returning to avoid upstream retries

Link to tracking issue

Testing

Documentation

@carsonip carsonip changed the title [exporter/elasticsearch] Log metrics validation error instead of returning to avoid upstream retries [exporter/elasticsearch] Log and drop invalid metrics instead of returning error to avoid upstream retries Oct 11, 2024
@carsonip carsonip marked this pull request as ready for review October 11, 2024 11:31
@carsonip carsonip requested a review from a team as a code owner October 11, 2024 11:31
@carsonip carsonip requested a review from mwear October 11, 2024 11:31
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrzej-stencel andrzej-stencel merged commit e6c14a5 into open-telemetry:main Oct 15, 2024
160 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 15, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…rning error to avoid upstream retries (open-telemetry#35740)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Log metrics validation error instead of returning to avoid upstream
retries

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants