[receiver/awsfirehosereceiver] make otlp_v1 a valid record type #35750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
approved these changes
Oct 24, 2024
mwear
reviewed
Oct 24, 2024
mx-psi
pushed a commit
that referenced
this pull request
Nov 4, 2024
…36125) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description After able to test E2E with #35750, I realized `otlp_v1` is still treated as an invalid record type because it's missing from the unmarshalers map. This PR is to add it into the map, enhance the error message output to show the `record_type` and add a test yaml file.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…-telemetry#35750) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR is to add `otlp_v1` into the list of valid `record_type` input. Otherwise when `record_type` sets to `otlp_v1`, we get error: ``` 2024-10-23T16:53:09.823Z info service@v0.112.0/service.go:135 Setting up own telemetry... 2024-10-23T16:53:09.824Z info telemetry/metrics.go:70 Serving metrics {"address": "localhost:8888", "metrics level": "Normal"} Error: failed to build pipelines: failed to create "awsfirehose" receiver for data type "metrics": unrecognized record type ``` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> --------- Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…pen-telemetry#36125) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description After able to test E2E with open-telemetry#35750, I realized `otlp_v1` is still treated as an invalid record type because it's missing from the unmarshalers map. This PR is to add it into the map, enhance the error message output to show the `record_type` and add a test yaml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add
otlp_v1into the list of validrecord_typeinput.Otherwise when
record_typesets tootlp_v1, we get error: