[connector, exporter/datadog] Enable compute_stats_by_span_kind and peer_tags_aggregation by default #35969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eer_tags_aggregation by default
github-actions
bot
added
connector/datadog
exporter/datadog
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
liustanley and
mackjmr
songy23
commented
Oct 23, 2024
mx-psi
approved these changes
Oct 24, 2024
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
LGTM. Do we need to request review from any other team at Datadog? Do we need to wait to merge this by some particualr date?
songy23
added
on hold
mx-psi
previously requested changes
Oct 24, 2024
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
Blocking merge per the comment above
pkalmakis
approved these changes
Oct 24, 2024
mx-psi
approved these changes
Dec 10, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…eer_tags_aggregation by default (open-telemetry#35969) #### Description Flip configs `traces::compute_stats_by_span_kind`, `traces::peer_tags_aggregation` and `traces::peer_service_aggregation` to true by default --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…eer_tags_aggregation by default (open-telemetry#35969) #### Description Flip configs `traces::compute_stats_by_span_kind`, `traces::peer_tags_aggregation` and `traces::peer_service_aggregation` to true by default --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…eer_tags_aggregation by default (open-telemetry#35969) #### Description Flip configs `traces::compute_stats_by_span_kind`, `traces::peer_tags_aggregation` and `traces::peer_service_aggregation` to true by default --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flip configs
traces::compute_stats_by_span_kind,traces::peer_tags_aggregationandtraces::peer_service_aggregationto true by default