[receiver/journald] adds byte array message parsing #36005
Merged
+63
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These appear to be two unrelated features. Please reduce this PR to one feature and open a separate PR for the other |
djaglowski
reviewed
Oct 28, 2024
fuero
force-pushed
the
feature/journald-features
branch
from
8677fe3 to
752b464
Compare
Sure, done: |
fuero
changed the title
djaglowski
approved these changes
Oct 29, 2024
|
Please add a changelog entry |
fuero
force-pushed
the
feature/journald-features
branch
from
09d1e7a to
b12093b
Compare
|
Just a couple lint errors to resolve, plus conflicts from #36031. |
fuero
force-pushed
the
feature/journald-features
branch
4 times, most recently
from
ac1bfee to
4d721e4
Compare
fuero
force-pushed
the
feature/journald-features
branch
from
4d721e4 to
c95551c
Compare
|
@djaglowski all done, thanks! |
zzhlogin
pushed a commit
to zzhlogin/opentelemetry-collector-contrib-aws
that referenced
this pull request
Nov 12, 2024
…6005) #### Description Adds message conversion from byte array support to journald receiver. Introduces a config setting for enabling this behaviour. #### Link to tracking issue Fixes open-telemetry#35964 #### Testing Adds tests for decoding a message successfully to string Tested on a real world example as well with the resulting binary #### Documentation Adds description of the setting the PR introduces
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…6005) #### Description Adds message conversion from byte array support to journald receiver. Introduces a config setting for enabling this behaviour. #### Link to tracking issue Fixes open-telemetry#35964 #### Testing Adds tests for decoding a message successfully to string Tested on a real world example as well with the resulting binary #### Documentation Adds description of the setting the PR introduces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds message conversion from byte array support to journald receiver.
Introduces a config setting for enabling this behaviour.
Link to tracking issue
Fixes #35964
Testing
Adds tests for decoding a message successfully to string
Tested on a real world example as well with the resulting binary
Documentation
Adds description of the setting the PR introduces