-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[receiver/sqlserver] Add SQL server host resource attributes #37004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/sqlserver] Add SQL server host resource attributes #37004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conflict need to be resolved, please help fix it, thanks!
2c367a8
to
e2fb7a5
Compare
hi, I’ve resolved the merge conflicts, but I noticed that the actions workflow is failing with a check-links error. I’m not entirely sure what this error refers to. could someone provide more details or guidance on how to address this issue? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
hi, I noticed that this PR has been marked as stale. Is there anyone available to review it? Please let me know if I can provider any additional information or make any improvements to help move it forward. Thanks! |
@LZiHaN Hello. I'll try to take a pass at it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LZiHaN I think it generally looks good aside from my comment. Do you have any screenshots of the new attributes hooked up to a live system?
sure! I can provide a screenshot of the logs showing the new attributes in action. Let me know if that works for you! |
Description
The new attribute are added to the SQL server receiver to distinguish metrics coming from different SQL server instances.
Link to tracking issue
refer to #35183
Testing
passes tests.
Documentation
no need to update.