Skip to content

[receiver/sqlserver] Add SQL server host resource attributes #37004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LZiHaN
Copy link
Member

@LZiHaN LZiHaN commented Jan 1, 2025

Description

The new attribute are added to the SQL server receiver to distinguish metrics coming from different SQL server instances.

  • server.address: The address of the SQL server host, enabled by default.
  • server.port: The port of the SQL server host, disabled by default.

Link to tracking issue

refer to #35183

Testing

passes tests.

Documentation

no need to update.

Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict need to be resolved, please help fix it, thanks!

@LZiHaN LZiHaN force-pushed the sqlserver-add-address-resource-attr branch from 2c367a8 to e2fb7a5 Compare January 18, 2025 10:24
@LZiHaN
Copy link
Member Author

LZiHaN commented Jan 18, 2025

There is a conflict need to be resolved, please help fix it, thanks!

hi, I’ve resolved the merge conflicts, but I noticed that the actions workflow is failing with a check-links error. I’m not entirely sure what this error refers to. could someone provide more details or guidance on how to address this issue?

Copy link
Contributor

github-actions bot commented Feb 6, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 6, 2025
@LZiHaN
Copy link
Member Author

LZiHaN commented Feb 6, 2025

hi, I noticed that this PR has been marked as stale. Is there anyone available to review it? Please let me know if I can provider any additional information or make any improvements to help move it forward. Thanks!

@StefanKurek
Copy link
Contributor

@LZiHaN Hello. I'll try to take a pass at it soon.

Copy link
Contributor

@StefanKurek StefanKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZiHaN I think it generally looks good aside from my comment. Do you have any screenshots of the new attributes hooked up to a live system?

@LZiHaN
Copy link
Member Author

LZiHaN commented Feb 7, 2025

@LZiHaN I think it generally looks good aside from my comment. Do you have any screenshots of the new attributes hooked up to a live system?

sure! I can provide a screenshot of the logs showing the new attributes in action. Let me know if that works for you!
image

@github-actions github-actions bot removed the Stale label Feb 7, 2025
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Feb 18, 2025
@MovieStoreGuy MovieStoreGuy merged commit e8de047 into open-telemetry:main Feb 20, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 20, 2025
@LZiHaN LZiHaN deleted the sqlserver-add-address-resource-attr branch February 20, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/sqlserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants