[chore][processor/probabilistic_sampler] Clarify the default sampling mode #37536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mode Fixes open-telemetry#36802. As per open-telemetry#36802 described, the sampling mode is always "hash_seed" if no mode is specified, regardless of the `hash_seed` or `attribute_source` field status. Update the README to reflect it. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
github-actions
bot
added
the
processor/probabilisticsampler
jmacd
approved these changes
Feb 3, 2025
jpkrohling
approved these changes
Feb 8, 2025
atoulme
added
the
ready to merge
MovieStoreGuy
approved these changes
Feb 12, 2025
khushijain21
pushed a commit
to khushijain21/opentelemetry-collector-contrib
that referenced
this pull request
Feb 14, 2025
… mode (open-telemetry#37536) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description As per open-telemetry#36802, the sampling mode is always "hash_seed" if no mode is specified, regardless of the `hash_seed` or `attribute_source` field status. Update the README to reflect it. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36802. Signed-off-by: Mengnan Gong <namco1992@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #36802, the sampling mode is always "hash_seed" if no mode is specified, regardless of the
hash_seedorattribute_sourcefield status. Update the README to reflect it.Link to tracking issue
Fixes #36802.