Skip to content

Commit

Permalink
Remove unused Settings struct.
Browse files Browse the repository at this point in the history
Fix Windows tests

Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
  • Loading branch information
pmatyjasek-sumo committed May 21, 2021
1 parent 13ca9f2 commit 5e910c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
12 changes: 0 additions & 12 deletions component/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ package component
import (
"context"

"go.uber.org/zap"

"go.opentelemetry.io/collector/config"
)

Expand Down Expand Up @@ -62,16 +60,6 @@ type Component interface {
Shutdown(ctx context.Context) error
}

// Settings is passed to ReceiverFactory.Create* functions.
type Settings struct {
// Logger that the factory can use during creation and can pass to the created
// component to be used later as well.
Logger *zap.Logger

// BuildInfo can be used by components for informational purposes
BuildInfo BuildInfo
}

// Kind represents component kinds.
type Kind int

Expand Down
2 changes: 1 addition & 1 deletion service/application_windows_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func TestWindowsService_Execute(t *testing.T) {
factories, err := defaultcomponents.Components()
require.NoError(t, err)

s := NewWindowsService(svcSettings{BuildInfo: component.DefaultBuildInfo(), Factories: factories})
s := NewWindowsService(AppSettings{BuildInfo: component.DefaultBuildInfo(), Factories: factories})

appDone := make(chan struct{})
requests := make(chan svc.ChangeRequest)
Expand Down

0 comments on commit 5e910c6

Please sign in to comment.