From 667432ca86439611ad076ac273c19899746b09c2 Mon Sep 17 00:00:00 2001 From: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> Date: Mon, 3 Apr 2023 11:32:36 -0400 Subject: [PATCH] Clarify non-permanent error handling in receiver/doc.go See discussion here https://github.com/open-telemetry/opentelemetry-collector/pull/7459#discussion_r1156077884 It is expected that the receivers should always retry, not just that they may retry. --- receiver/doc.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/receiver/doc.go b/receiver/doc.go index 37c230eab9d..1e88134c499 100644 --- a/receiver/doc.go +++ b/receiver/doc.go @@ -32,7 +32,7 @@ // receiving protocol allows to do that. In case of OTLP/HTTP for example, this means // that HTTP 400 response is returned to the sender. // -// If the error is non-Permanent then the nextConsumer.Consume*() call may be retried +// If the error is non-Permanent then the nextConsumer.Consume*() call should be retried // with the same data. This may be done by the receiver itself, however typically it is // done by the original sender, after the receiver returns a response to the sender // indicating that the Collector is currently overloaded and the request must be