Skip to content

Commit

Permalink
Remove QueueSettings (#3210)
Browse files Browse the repository at this point in the history
The Promeheus Remote Write exporter is not using the retried queue. Error if the user confiugration has QueueSettings.

Note: This is a breaking change and we might want to keep it not to break the existing collector configs.
  • Loading branch information
rakyll authored May 18, 2021
1 parent 11fdea8 commit 8391c1e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion exporter/prometheusremotewriteexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
type Config struct {
config.ExporterSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct
exporterhelper.TimeoutSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct.
exporterhelper.QueueSettings `mapstructure:"sending_queue"`
exporterhelper.RetrySettings `mapstructure:"retry_on_failure"`

// prefix attached to each exported metric name
Expand Down
1 change: 0 additions & 1 deletion exporter/prometheusremotewriteexporter/exporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func Test_NewPrwExporter(t *testing.T) {
cfg := &Config{
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
TimeoutSettings: exporterhelper.TimeoutSettings{},
QueueSettings: exporterhelper.QueueSettings{},
RetrySettings: exporterhelper.RetrySettings{},
Namespace: "",
ExternalLabels: map[string]string{},
Expand Down

0 comments on commit 8391c1e

Please sign in to comment.