review comments: use slice to append errors

receiver/scraperhelper/scrapercontroller.go

@@ -143,12 +143,12 @@ func (sc *controller) Shutdown(ctx context.Context) error {
  <-sc.terminated
  }
 
- var errs error
+ var errs []error
  for _, scraper := range sc.scrapers {
- errs = errors.Join(errs, scraper.Shutdown(ctx))
+ errs = append(errs, scraper.Shutdown(ctx))
  }
 
- return errs
+ return errors.Join(errs...)
 }
 
 // startScraping initiates a ticker that calls Scrape based on the configured

receiver/scraperhelper/scrapercontroller_test.go

@@ -247,15 +247,15 @@ func getExpectedStartErr(test metricsTestCase) error {
 }
 
 func getExpectedShutdownErr(test metricsTestCase) error {
- var errs error
+ var errs []error
 
  if test.closeErr != nil {
  for i := 0; i < test.scrapers; i++ {
- errs = errors.Join(errs, test.closeErr)
+ errs = append(errs, test.closeErr)
  }
  }
 
- return errs
+ return errors.Join(errs...)
 }
 
 func assertChannelsCalled(t *testing.T, chs []chan bool, message string) {

receiver/scraperhelper/settings.go

@@ -40,12 +40,13 @@ func NewDefaultScraperControllerSettings(component.Type) ScraperControllerSettin
  }
 }
 
-func (set *ScraperControllerSettings) Validate() (errs error) {
+func (set *ScraperControllerSettings) Validate() error {
+ var errs []error
  if set.CollectionInterval <= 0 {
- errs = errors.Join(errs, fmt.Errorf(`"collection_interval": %w`, errNonPositiveInterval))
+ errs = append(errs, fmt.Errorf(`"collection_interval": %w`, errNonPositiveInterval))
  }
  if set.Timeout < 0 {
- errs = errors.Join(errs, fmt.Errorf(`"timeout": %w`, errNonPositiveInterval))
+ errs = append(errs, fmt.Errorf(`"timeout": %w`, errNonPositiveInterval))
  }
- return errs
+ return errors.Join(errs...)
 }