Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change obsreport helpers for receiver to use the same pattern as Processor/Exporter #2649

Closed
bogdandrutu opened this issue Mar 10, 2021 · 4 comments
Assignees
Labels
area:miscellaneous help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release

Comments

@bogdandrutu
Copy link
Member

  • Define a struct and helpers similar with ProcessorObsReport (it will be renamed to just Processor)
@bogdandrutu bogdandrutu added this to the Phase1-GA-Roadmap milestone Mar 10, 2021
@bogdandrutu bogdandrutu added area:miscellaneous help wanted Good issue for contributors to OpenTelemetry Service to pick up labels Mar 10, 2021
@bhautikpip
Copy link
Contributor

bhautikpip commented May 5, 2021

@bogdandrutu I could not find similar name pattern any more in any of the file in obsreport package. I also checked obsreport_receiver.go for more sanity. I think PR #2658 and #2657 covered most of the changes. Am I missing anything here?

@alolita
Copy link
Member

alolita commented May 12, 2021

@bogdandrutu is this still an open issue? Looks like the changes have already been made.

@bogdandrutu
Copy link
Member Author

bogdandrutu commented May 14, 2021

@bhautikpip those PRs are for exporters and processors, but for the Receiver/Scraper we have a completely different API that uses global functions instead of a per receiver object. So look at these APIs:

We need them to be consistent.

@alolita the work done was to improve processor and exporter but nothing done for the receiver/scraper.

@alolita
Copy link
Member

alolita commented Jun 17, 2021

Pending PR #3327 to be merged.

@alolita alolita closed this as completed Jun 23, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:miscellaneous help wanted Good issue for contributors to OpenTelemetry Service to pick up release:required-for-ga Must be resolved before GA release
Projects
None yet
Development

No branches or pull requests

5 participants