Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra closing parenthesis in sub-config error #10479

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

rogercoll
Copy link
Contributor

Description

Removed an extra closing parenthesis. This corrects the formatting of the error message for unexpected sub-config value kinds.

Found in: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33268/files#diff-9137db5fde5eb0d6870425c0023cec1a5bdfe92f58f8a72e278b55635afc6e95R48

Link to tracking issue

Testing

Documentation

Removed an extra closing parenthesis. This corrects the formatting of the
 error message for unexpected sub-config value kinds.
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.34%. Comparing base (a082f2e) to head (15870f5).

Files Patch % Lines
confmap/confmap.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10479   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         393      393           
  Lines       18621    18621           
=======================================
  Hits        17196    17196           
  Misses       1068     1068           
  Partials      357      357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rogercoll rogercoll marked this pull request as ready for review June 28, 2024 11:13
@rogercoll rogercoll requested review from a team and dmitryax June 28, 2024 11:13
@rogercoll
Copy link
Contributor Author

Added a changelog entry in case other the tests of confmap users start to fail with the new release.

@codeboten codeboten merged commit c6e3c4e into open-telemetry:main Jul 2, 2024
49 of 50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 2, 2024
@rogercoll rogercoll deleted the fix_error_format branch July 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants