Promote confmap.strictlyTypedInput feature gate to beta #10554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2024
mx-psi
added
the
release:blocker
mx-psi
added a commit
that referenced
this pull request
Jul 8, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Uses string type for `unit` field in mdatagen related files. <!-- Issue number if applicable --> #### Link to tracking issue Needed for #10554
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 8, 2024
Uses string type for `unit` field in mdatagen related files. **Link to tracking Issue:** Needed for open-telemetry/opentelemetry-collector/pull/10554
mx-psi
added a commit
that referenced
this pull request
Jul 9, 2024
…0559) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Adds string representation to all inputs returned by mock env provider used in tests. The real `env` provider (and all other providers on this repository) do this by default since they use `NewRetrievedFromYAML`. Note that certain types are not really obtainable with the real `env` provider (e.g. `int32` or `float64`). I have kept them and added the string representation manually. #### Link to tracking issue Needed for #10554 Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 9, 2024
**Description:** `headers` values are `configopaque.String`s, so integers make `confmap` sad **Link to tracking Issue:** Needed for open-telemetry/opentelemetry-collector/pull/10554
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10554 +/- ##
==========================================
- Coverage 92.34% 92.28% -0.06%
==========================================
Files 395 395
Lines 18686 18686
==========================================
- Hits 17255 17244 -11
- Misses 1070 1084 +14
+ Partials 361 358 -3 ☔ View full report in Codecov by Sentry. |
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 10, 2024
…version (#33992) Changes examples for `api_version` to make sure they use a string instead of a float **Link to tracking Issue:** Required for open-telemetry/opentelemetry-collector/pull/10554
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
Make room for open-telemetry/opentelemetry-collector#10554 --------- Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
codeboten
approved these changes
Jul 11, 2024
songy23
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes type resolution strict and conforming to the behavior described in the env vars RFC
Depends on:
confmap.strictlyTypedInputfeature gate #10553Link to tracking issue
Fixes #9532, Fixes #8565