Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecation comment and log message #1786

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

rf232
Copy link
Contributor

@rf232 rf232 commented Sep 15, 2020

Make the comment and log message match the actual constant used in the deprecation logic.

Make the comment and log message match the actual constant used in the deprecation logic.
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1786 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
- Coverage   91.66%   91.65%   -0.01%     
==========================================
  Files         261      261              
  Lines       18532    18525       -7     
==========================================
- Hits        16987    16980       -7     
  Misses       1114     1114              
  Partials      431      431              
Impacted Files Coverage Δ
consumer/pdata/generated_common.go 100.00% <100.00%> (ø)
consumer/pdata/generated_log.go 100.00% <100.00%> (ø)
consumer/pdata/generated_metrics.go 100.00% <100.00%> (ø)
consumer/pdata/generated_trace.go 100.00% <100.00%> (ø)
internal/data/testdata/metric.go 100.00% <100.00%> (ø)
processor/batchprocessor/splittraces.go 97.05% <100.00%> (ø)
processor/groupbytraceprocessor/processor.go 100.00% <100.00%> (ø)
processor/resourceprocessor/factory.go 100.00% <100.00%> (ø)
...babilisticsamplerprocessor/probabilisticsampler.go 89.83% <100.00%> (ø)
receiver/fluentforwardreceiver/conversion.go 89.63% <100.00%> (-0.10%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96643c6...d9c7937. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 6b4dce0 into open-telemetry:master Sep 15, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
… name (open-telemetry#1777) (open-telemetry#1786)

Signed-off-by: lastchiliarch <lastchiliarch@163.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1786)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.30 to 1.24.31.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.30...1.24.31)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants