Authentication processor 3/4 - Add implementation #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
This was referenced Sep 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
+ Coverage 91.16% 91.19% +0.03%
==========================================
Files 271 272 +1
Lines 16235 16337 +102
==========================================
+ Hits 14801 14899 +98
- Misses 1008 1010 +2
- Partials 426 428 +2
Continue to review full report at Codecov.
|
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-3
branch
from
007f9f9
to
69ebc55
Compare
|
Please rebase |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-3
branch
from
69ebc55
to
b41363e
Compare
jpkrohling
commented
Sep 24, 2020
| } | ||
|
|
||
| func (o *oidcAuthenticator) UnaryInterceptor(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { | ||
| return o.unaryInterceptor(ctx, req, info, handler, o.Authenticate) |
There was a problem hiding this comment.
@bogdandrutu just realized that moving this to config/configauth/internal might be easier than I thought. I'd still do it in a follow-up PR if you agree.
|
Any news on this one? |
|
Ping @bogdandrutu |
bogdandrutu
approved these changes
Sep 28, 2020
| return nil | ||
| } | ||
|
|
||
| func (o *oidcAuthenticator) Close() error { |
There was a problem hiding this comment.
In a different PR, rename to Shutdown and pass Context.
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added the OIDC authenticator. Split from #1728.
This PR is based on top of #1808.
Link to tracking Issue: Part of the solution for #1424.
Testing: unit tests.
Documentation: none.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de