2a/3 Update hostmetrics disk scraper to use new perfcounters package #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
james-bebbington
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1836 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 263 263
Lines 16105 16105
=======================================
Hits 14675 14675
Misses 1003 1003
Partials 427 427 Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
hostmetrics-disk-perfib
branch
from
18c9666
to
6c9ad22
Compare
james-bebbington
force-pushed
the
hostmetrics-disk-perfib
branch
2 times, most recently
from
8721ae3
to
ec9875b
Compare
james-bebbington
changed the title
james-bebbington
force-pushed
the
hostmetrics-disk-perfib
branch
2 times, most recently
from
47247b3
to
a645c76
Compare
james-bebbington
force-pushed
the
hostmetrics-disk-perfib
branch
from
a645c76
to
6f682e3
Compare
bogdandrutu
approved these changes
Sep 28, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1836) Bumps [boto3](https://github.com/boto/boto3) from 1.24.44 to 1.24.45. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.44...1.24.45) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #973
Description:
1. Add new perflib package
2. Migrate host metrics scrapers to use new package
3. Remove third_party PDH code
Depends on #1835