Add batched exports to the Prometheus Remote Write Exporter #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 1, 2020 11:28
Codecov Report
@@ Coverage Diff @@
## master #2249 +/- ##
==========================================
+ Coverage 91.98% 92.01% +0.03%
==========================================
Files 271 271
Lines 15664 15681 +17
==========================================
+ Hits 14408 14429 +21
+ Misses 854 851 -3
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
|
@huyan0 will you be able to review this as the original author of the exporter? |
|
@amanbrar1999 is actually the current maintainer from AWS for the Prometheus Remote Write Exporter. Would also be great if we could get a review from @jmacd. Thank you! cc - @alolita |
huyan0
approved these changes
Dec 8, 2020
rakyll
approved these changes
Dec 9, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Add sfx_skip_repo option to ansible * rename sfx_skip_repo to splunk_skip_repo, add the when clause to debian installs as well, add more documentation Co-authored-by: asavenko <asavenko@redhat.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, there is no limit on the size of the remote_write export request to a Cortex instance. This could create problems if one Prometheus scrape produces an extreme amount of timeseries metrics.
This PR creates a batch of concurrent requests where the max size of a request is 3MB and the max number of timeseries per request is 40,000.
A future PR will tackle making the max size of each request configurable.
Testing: