Minor changes to Obsreport #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
james-bebbington
changed the title
| tag.Upsert(tagKeyTransport, transport, tag.WithTTL(tag.TTLNoPropagation)), | ||
| mutators := make([]tag.Mutator, 0, 2) | ||
| mutators = append(mutators, tag.Upsert(tagKeyReceiver, receiver, tag.WithTTL(tag.TTLNoPropagation))) | ||
| if transport != "" { |
There was a problem hiding this comment.
Not totally sure about using the empty string to signify an optional parameter, but it seems fairly idiomatic from what I can tell, and has the advantage here of being a non-breaking change.
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
=======================================
Coverage 85.52% 85.52%
=======================================
Files 184 184
Lines 13545 13546 +1
=======================================
+ Hits 11584 11585 +1
Misses 1498 1498
Partials 463 463
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
obsreport-minor-updates
branch
from
888b426
to
dbf4145
Compare
…ons and added a note about MetricCount when using the new internal data structure
james-bebbington
force-pushed
the
obsreport-minor-updates
branch
from
dbf4145
to
8f1505f
Compare
dmitryax
approved these changes
May 11, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…ons and added a note about MetricCount when using the new internal data structure (open-telemetry#942)
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…obuf bindings locally (open-telemetry#942) * Import open-telemetry/opentelemetry-proto submodule under internal * Commit changes in updated/new protobuf files * Refer to new location of .pb.go files after rewrite from import * Describe in CHANGELOG
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue:
#918
Description:
Made the "transport" parameter that's used to set a corresponding attribute value optional for obsreport receiver functions. This parameter doesn't make sense for all receivers.
Also added a comment regarding using the internal data structure with the CountMetricPoints function.