Feature to add Nginx variables related to tracing context #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalff
added
the
Webserver
DebajitDas
reviewed
Apr 29, 2024
| @@ -863,7 +990,7 @@ static OTEL_SDK_STATUS_CODE otel_startInteraction(ngx_http_request_t* r, const c | |||
| { | |||
| resolveBackends = conf->nginxModuleResolveBackends; | |||
| } | |||
| OTEL_SDK_ENV_RECORD* propagationHeaders = ngx_pcalloc(r->pool, 5 * sizeof(OTEL_SDK_ENV_RECORD)); | |||
| OTEL_SDK_ENV_RECORD* propagationHeaders = ngx_pcalloc(r->pool, 6 * sizeof(OTEL_SDK_ENV_RECORD)); | |||
There was a problem hiding this comment.
Can we have some variable instead of magic number?
| @@ -894,6 +1022,113 @@ static OTEL_SDK_STATUS_CODE otel_startInteraction(ngx_http_request_t* r, const c | |||
| } | |||
| return res; | |||
| } | |||
| static void otel_variables_decorator(ngx_http_request_t* r){ | |||
There was a problem hiding this comment.
Can we add some comments on what we are trying to achieve here? Because the code seems complex and not very intuitive to understand?
| ngx_uint_t key; // The variable's hashed key. | ||
| ngx_http_variable_value_t *value; // Pointer to the value object. | ||
|
|
||
| if(var_name.data[0] == '$'){ |
There was a problem hiding this comment.
what is the meaning of dollar? Is it delimiter? Please add some varieable and use it
There was a problem hiding this comment.
'$' is used to identify Nginx Variables, as they have to start woth '$' sign. Will a comment work here ?
DebajitDas
approved these changes
Apr 29, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
Added 4 nginx variables $opentelemetry_trace_id, $opentelemetry_span_id, $opentelemetry_context_traceparent, $opentelemetry_context_b3 which can be accessed from the .conf files and can be used as needed.