Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing root span attributes and a Directive to configure root span name (operation name) #428

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Adding missing root span attributes and a Directive to configure root span name (operation name) #428

merged 7 commits into from
Apr 12, 2024

Conversation

aryanishan1001
Copy link
Contributor

@aryanishan1001 aryanishan1001 commented Apr 10, 2024 •
edited
Loading

Added two features -

  1. $remote_port and User-Agent header value was added as a root span attribute.
  2. NginxModuleOperationName directive is introduced, it can be used specify root span name directly for endpoints.

#404
#362

@aryanishan1001 aryanishan1001 requested a review from a team April 10, 2024 01:43
DebajitDas
DebajitDas approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@DebajitDas DebajitDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DebajitDas DebajitDas merged commit 2cd18f6 into open-telemetry:main Apr 12, 2024
5 checks passed
@marcalff marcalff added the Webserver This represents the otel-webserver-module in the instrumentation directory label May 15, 2024
@aryanishan1001 aryanishan1001 mentioned this pull request Aug 15, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebajitDas DebajitDas DebajitDas approved these changes

@kpratyus kpratyus Awaiting requested review from kpratyus kpratyus is a code owner

Assignees
No one assigned
Labels
Webserver This represents the otel-webserver-module in the instrumentation directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryanishan1001 @DebajitDas @marcalff