From 5df066cf2b48e745e7f33398e753a53cbd70be5d Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Wed, 4 Aug 2021 22:21:21 -0700 Subject: [PATCH] Revert "Update default OTLP http port (#939)" This reverts commit 05444a8ca48c9067f51e87f3668357a37dc671b5. --- exporters/otlp/README.md | 7 +++---- .../opentelemetry/exporters/otlp/otlp_http_exporter.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/exporters/otlp/README.md b/exporters/otlp/README.md index cc2c4510e6..8c6efe90d3 100644 --- a/exporters/otlp/README.md +++ b/exporters/otlp/README.md @@ -44,10 +44,9 @@ auto exporter = std::unique_ptr(new otlp::OtlpHttpExport ### Configuration options -| Option | Default | -| ------------------------------------ |----------------- | -| `OtlpGrpcExporterOptions.endpoint` | `localhost:4317` | -| `OtlpHttpExporterOptions.endpoint` | `localhost:4318` | +| Option | Default | +| ------------ |----------------- | +| `endpoint` | `localhost:4317` | ## Example diff --git a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h index 5088409adb..0d6f04e653 100644 --- a/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h +++ b/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h @@ -50,7 +50,7 @@ struct OtlpHttpExporterOptions // @see // https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md // @see https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver - std::string url = std::string("http://localhost:4318") + kDefaultTracePath; + std::string url = std::string("http://localhost:4317") + kDefaultTracePath; // By default, post json data HttpRequestContentType content_type = HttpRequestContentType::kJson;