Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[follow up] update of message Location #147

Closed
florianl opened this issue Sep 2, 2024 · 3 comments
Closed

[follow up] update of message Location #147

florianl opened this issue Sep 2, 2024 · 3 comments

Comments

@florianl
Copy link
Contributor

florianl commented Sep 2, 2024

With open-telemetry/semantic-conventions#1188 a semantic convention will be introduced for profiles. These new attributes should be used as replacement for message Location.type_index, which will be removed with open-telemetry/opentelemetry-proto#578.

Once a new version of OTel semantic convention is released, that includes open-telemetry/semantic-conventions#1188, package reporter should be updated and

  1. Remove Location.TypeIndex - see
    TypeIndex: getStringMapIndex(stringMap,
    traceInfo.frameTypes[i].String()),
  2. Use these new attributes in message Location
@Rajamanosankari
Copy link

I would like to work on this.

@florianl
Copy link
Contributor Author

Location.TypeIndex will be removed with #167 and replaced with semantic convention attributes.

@florianl
Copy link
Contributor Author

Closing as resolved with #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants