Add AWS X-Ray ID Generator #459

wilguo · 2020-11-18T17:42:28Z

This PR adds an ID Generator for sending traces to AWS X-Ray as well as unit tests for testing the ID Generator.

The core functionalities include:

NewTraceID() which generates a new Trace ID based on AWS X-Ray TraceID Format
NewSpanID() which generates a new Span ID from a randomly-chosen sequence

Aneurysm9

Please create a separate module for idgenerator/aws. This should ensure that it can be imported independently and doesn't result in additional imports for users of contrib packages that don't use it.

idgenerator/aws/aws_xray_idgenerator.go

wilguo · 2020-11-18T22:11:46Z

Hi @Aneurysm9,

I've added a separate module for idgenerator/aws however now it's giving me an error when I run make precommit.

missing go.mod dependabot check:
./idgenerator/aws
make: *** [dependabot-check] Error 1

I'm assuming I didn't add a line for the dependabot somewhere, but not sure where to add this check. Could you point me in the right direction? Thank you!

Aneurysm9 · 2020-11-18T22:59:09Z

I'm assuming I didn't add a line for the dependabot somewhere, but not sure where to add this check. Could you point me in the right direction? Thank you!

You'll need to update .github/dependabot.yml to include an entry for the new module.

idgenerator/aws/aws_xray_idgenerator.go

CHANGELOG.md

idgenerator/aws/aws_xray_idgenerator.go

idgenerator/aws/xray/aws_xray_idgenerator.go

rakyll

Thanks, this generally looks good. I left a comment about the package's place.

idgenerator/aws/xray/aws_xray_idgenerator.go

.github/dependabot.yml

idgenerator/aws/xray/aws_xray_idgenerator.go

propagators/aws/xray/xrayidgenerator/aws_xray_idgenerator.go

alolita · 2020-12-02T01:42:36Z

@MrAlias @Aneurysm9 can you please re-review @wilguo's changes and merge? We're blocked on this. Ty!

go.sum

propagators/aws/xray/idgenerator.go

propagators/aws/xray/idgenerator_test.go

CHANGELOG.md

wilguo · 2020-12-11T17:52:38Z

@Aneurysm9 would it be the same if I make a new commit resolving all the conflicts?

possibly, though probably safer to revert and re-apply.

@Aneurysm9 I have reverted the commit, but the circlci is failing, is there a step I'm missing?

not relevant anymore

propagators/aws/go.mod

propagators/aws/xray/idgenerator_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* add simplified export pipeline setup for Jaeger * add With* options to configure SDK options. * add test for WithRegistration and WithSDK * rename Registeration with RegisterGlobal * rename WithRegistration to RegisterAsGlobal Co-authored-by: rahulpa <rahulpa@google.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>

wilguo requested review from Aneurysm9, evantorrie, jmacd, lizthegrey, MrAlias and XSAM as code owners November 18, 2020 17:42

Aneurysm9 reviewed Nov 18, 2020

View reviewed changes

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

wilguo requested a review from Aneurysm9 November 18, 2020 23:38

Aneurysm9 suggested changes Nov 19, 2020

View reviewed changes

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

wilguo requested a review from Aneurysm9 November 19, 2020 20:59

MrAlias requested changes Nov 19, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

idgenerator/aws/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

wilguo mentioned this pull request Nov 19, 2020

Provide extensibility of the SDK to support vendor specific ID Generators open-telemetry/opentelemetry-go#1351

Closed

rakyll reviewed Nov 20, 2020

View reviewed changes

wilguo added a commit to open-o11y/opentelemetry-go-contrib that referenced this pull request Nov 23, 2020

Make changes based on PR (open-telemetry#459)

3aef60a

rakyll approved these changes Nov 25, 2020

View reviewed changes

idgenerator/aws/xray/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

idgenerator/aws/xray/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

.github/dependabot.yml Outdated Show resolved Hide resolved

anuraaga reviewed Nov 25, 2020

View reviewed changes

idgenerator/aws/xray/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

wilguo referenced this pull request in open-o11y/opentelemetry-go-contrib Nov 25, 2020

Make changes based on PR comments (#459)

4c72001

Aneurysm9 approved these changes Nov 27, 2020

View reviewed changes

idgenerator/aws/xray/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

wilguo added a commit to open-o11y/opentelemetry-go-contrib that referenced this pull request Nov 27, 2020

Make changes based on PR (open-telemetry#459)

6a341d4

wilguo referenced this pull request in open-o11y/opentelemetry-go-contrib Nov 27, 2020

Make changes based on PR comments (#459)

a33ff23

wilguo force-pushed the wilguo-idgenerator branch from 1b5a5c9 to 62a60ba Compare November 27, 2020 23:30

wilguo requested a review from MrAlias November 27, 2020 23:44

wilguo mentioned this pull request Nov 28, 2020

Add AWS X-Ray Propagator #462

Merged

XSAM approved these changes Nov 29, 2020

View reviewed changes

dashpole reviewed Nov 30, 2020

View reviewed changes

propagators/aws/xray/xrayidgenerator/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

propagators/aws/xray/xrayidgenerator/aws_xray_idgenerator.go Outdated Show resolved Hide resolved

MrAlias previously requested changes Dec 3, 2020

View reviewed changes

MrAlias reviewed Dec 3, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

wilguo added a commit to open-o11y/opentelemetry-go-contrib that referenced this pull request Dec 11, 2020

Make changes based on PR (open-telemetry#459)

ad54342

wilguo referenced this pull request in open-o11y/opentelemetry-go-contrib Dec 11, 2020

Make changes based on PR comments (#459)

083d251

wilguo force-pushed the wilguo-idgenerator branch 2 times, most recently from 40454ab to fb1ebbf Compare December 11, 2020 22:36

Add ID Generator

75a16fe

wilguo force-pushed the wilguo-idgenerator branch from fb1ebbf to 0156c0b Compare December 11, 2020 23:16

Fix sdktrace dependency issue

88631cd

wilguo force-pushed the wilguo-idgenerator branch from 0156c0b to 88631cd Compare December 11, 2020 23:25

wilguo added 4 commits December 11, 2020 15:29

Add go.mod under aws

4dc8bc3

Update changelog and add go.mod files

17aafce

Modify go.sum

4ec00ca

Merge branch 'master' into wilguo-idgenerator

5f4c1fb

MrAlias requested changes Dec 14, 2020

View reviewed changes

propagators/aws/go.mod Outdated Show resolved Hide resolved

MrAlias reviewed Dec 14, 2020

View reviewed changes

wilguo and others added 8 commits December 14, 2020 08:25

Update propagators/aws/go.mod

91efe82

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

0068f13

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

0361a57

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

96deaec

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

cacf6c6

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

017d5df

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

a280500

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Update propagators/aws/xray/idgenerator_test.go

d8a1812

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

wilguo requested a review from MrAlias December 14, 2020 17:16

MrAlias approved these changes Dec 14, 2020

View reviewed changes

MrAlias merged commit f899260 into open-telemetry:master Dec 14, 2020

Aneurysm9 mentioned this pull request Dec 14, 2020

Prepare for releasing v0.15.1 #496

Merged

pellared added this to the untracked milestone Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AWS X-Ray ID Generator #459

Add AWS X-Ray ID Generator #459

wilguo commented Nov 18, 2020

Aneurysm9 left a comment

wilguo commented Nov 18, 2020

Aneurysm9 commented Nov 18, 2020

rakyll left a comment

alolita commented Dec 2, 2020

wilguo commented Dec 11, 2020

Add AWS X-Ray ID Generator #459

Add AWS X-Ray ID Generator #459

Conversation

wilguo commented Nov 18, 2020

Aneurysm9 left a comment

Choose a reason for hiding this comment

wilguo commented Nov 18, 2020

Aneurysm9 commented Nov 18, 2020

rakyll left a comment

Choose a reason for hiding this comment

alolita commented Dec 2, 2020

wilguo commented Dec 11, 2020