tests(otelhttp): fixes the body replacement in otelhttp to not to mutate a nil body. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
…ate a nil body. This might break tests when they attempt to read the body when the body isn't nil.
jcchavezs
force-pushed
the
fix_handler_observer_effect
branch
from
11d34b9 to
18cb7b6
Compare
|
@jmacd could you please review/merge this? This PR fixes a bug that is affecting us. |
Aneurysm9
reviewed
Dec 10, 2020
| if isReqBodyNil { | ||
| setAfterServeAttributes(span, 0, rww.written, rww.statusCode, nil, rww.err) | ||
| } else { | ||
| setAfterServeAttributes(span, bw.read, rww.written, rww.statusCode, bw.err, rww.err) |
There was a problem hiding this comment.
Can you avoid these conditionals by setting bw to an empty bodyWrapper above and not replacing r.Body with it? It looks like these are just providing the empty values for those fields if the request body is nil.
There was a problem hiding this comment.
Sounds like a good idea. Let me try that.
|
@XSAM @Aneurysm9 could we please include this in 0.15? |
XSAM
requested changes
Dec 11, 2020
There was a problem hiding this comment.
@Aneurysm9 Since we do not actually release the v0.15.0 tag, maybe we should include this?
@jchengsfx The last commit fails the compilation.
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
|
@XSAM done |
XSAM
approved these changes
Dec 12, 2020
Aneurysm9
approved these changes
Dec 12, 2020
|
Thanks all, shall we merge it?
On Sat, 12 Dec 2020 at 10:25, Anthony Mirabella ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#484 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYARPQNXPBM3DETGMSBDSUMZJTANCNFSM4USN7GEQ>
.
--
|
jcchavezs
added a commit
to hypertrace/goagent
that referenced
this pull request
Dec 14, 2020
This upgrade aims to prepare goagent to include the changes in open-telemetry/opentelemetry-go-contrib#484 in the next commit.
jcchavezs
added a commit
to hypertrace/goagent
that referenced
this pull request
Dec 14, 2020
…b#484 in the opentelemetry contrib dependency.
jcchavezs
added a commit
to hypertrace/goagent
that referenced
this pull request
Dec 14, 2020
* chore(opentelemetry): upgrades opentelemetry to 0.15.0. This upgrade aims to prepare goagent to include the changes in open-telemetry/opentelemetry-go-contrib#484 in the next commit. * chore(opentelemetry): includes open-telemetry/opentelemetry-go-contrib#484 in the opentelemetry contrib dependency. * tests(opencensus): improves coverage of the setAttribute method. * tests(opentelemetry): adds coverage for setAttribute.
6 tasks
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
…tallNewPipeline (#484) Co-authored-by: Rahul Patel <rghetia@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might break tests when they attempt to read the body when the body isn't nil.
When using a http server, the body received by the handler is
http.noBodywhereas when calling directly the handler it receivesnil. Whether calling the handler directly with a request is the best way to do it or not, by adding the handler in tests we get anilpointer as any attempt to read a nonnilbody ends up trying to read aio.ReadCloserwhich is actuallynil(and ends up in anil pointerfatal error). This creates the so called "observer effect".Related to hypertrace/goagent#66
Ping @XSAM @MrAlias @Aneurysm9