From 73c09c4454ebe5dc8762b44bc110174583b7515f Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Wed, 22 May 2024 09:10:21 -0700 Subject: [PATCH 1/3] Deprecate the AWS EC2 detector --- CHANGELOG.md | 5 +++++ detectors/aws/ec2/ec2.go | 9 +++++++++ detectors/aws/ec2/go.mod | 1 + 3 files changed, 15 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 90a375fa7a9..72aa9f1982e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ## [Unreleased] +### Deprecated + +- The `go.opentelemetry.io/contrib/detectors/aws/ec2` package is deprecated. + If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#TBD) + ## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21 ### Added diff --git a/detectors/aws/ec2/ec2.go b/detectors/aws/ec2/ec2.go index ee8aade2ed6..4c46139b5c0 100644 --- a/detectors/aws/ec2/ec2.go +++ b/detectors/aws/ec2/ec2.go @@ -1,6 +1,15 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 +// Package ec2 provide an OpenTelemetry resource detector for AWS EC2 +// instances. +// +// Deprecated: otelmongo has no Code Owner. +// After August 21, 2024, it may no longer be supported and may stop +// receiving new releases unless a new Code Owner is found. See +// [this issue] if you would like to become the Code Owner of this module. +// +// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542 package ec2 // import "go.opentelemetry.io/contrib/detectors/aws/ec2" import ( diff --git a/detectors/aws/ec2/go.mod b/detectors/aws/ec2/go.mod index f3b2a305617..b16ca3509e8 100644 --- a/detectors/aws/ec2/go.mod +++ b/detectors/aws/ec2/go.mod @@ -1,3 +1,4 @@ +// Deprecated: otelmongo has no Code Owner. module go.opentelemetry.io/contrib/detectors/aws/ec2 go 1.21 From c91010d14b1226e2abe14f154367f7a1ffbec172 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Wed, 22 May 2024 09:12:42 -0700 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 72aa9f1982e..4e122152d40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ### Deprecated - The `go.opentelemetry.io/contrib/detectors/aws/ec2` package is deprecated. - If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#TBD) + If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#5636) + +[#5542]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542 ## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21 From 35c689ba0b2f640ae2162a9d6e0a2649335b9d09 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Wed, 22 May 2024 09:17:21 -0700 Subject: [PATCH 3/3] Apply suggestions from code review --- detectors/aws/ec2/ec2.go | 2 +- detectors/aws/ec2/go.mod | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/detectors/aws/ec2/ec2.go b/detectors/aws/ec2/ec2.go index 4c46139b5c0..cce1f0db5a2 100644 --- a/detectors/aws/ec2/ec2.go +++ b/detectors/aws/ec2/ec2.go @@ -4,7 +4,7 @@ // Package ec2 provide an OpenTelemetry resource detector for AWS EC2 // instances. // -// Deprecated: otelmongo has no Code Owner. +// Deprecated: ec2 has no Code Owner. // After August 21, 2024, it may no longer be supported and may stop // receiving new releases unless a new Code Owner is found. See // [this issue] if you would like to become the Code Owner of this module. diff --git a/detectors/aws/ec2/go.mod b/detectors/aws/ec2/go.mod index b16ca3509e8..dde546bfa6e 100644 --- a/detectors/aws/ec2/go.mod +++ b/detectors/aws/ec2/go.mod @@ -1,4 +1,4 @@ -// Deprecated: otelmongo has no Code Owner. +// Deprecated: ec2 has no Code Owner. module go.opentelemetry.io/contrib/detectors/aws/ec2 go 1.21