Run genjsonschema in CI #6353
Open
Run genjsonschema in CI #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
the
Skip Changelog
dmathieu
force-pushed
the
ci-genjsonschema
branch
from
6a5ff57
to
2cac67e
Compare
pellared
reviewed
Nov 20, 2024
pellared
approved these changes
Nov 21, 2024
evan-bradley
approved these changes
Nov 21, 2024
pellared
approved these changes
Nov 21, 2024
|
CC @codeboten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6347 is updating the generated JSON schema, as it has changed with upgrades of
go-jsonschema.We update the binary semi automatically with dependabot. However, this means there could be unseen regressions or changes like this that we miss.
This runs the schema generation on CI, before checking for a clean repository, so we can keep the generated code up to date with the binary version.
This should fail until #6347 and #6349 are merged.