Skip to content

Commit

Permalink
update documentation for default of WithProxy option
Browse files Browse the repository at this point in the history
  • Loading branch information
MickaelAlliel committed Feb 25, 2024
1 parent b6d75e5 commit 26e48c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions exporters/otlp/otlpmetric/otlpmetrichttp/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ func WithAggregationSelector(selector metric.AggregationSelector) Option {

// WithProxy sets the Proxy function the client will use to determine the
// proxy to use for an HTTP request. If this option is not used, the client
// will use the default proxy settings from the
// exporters/otlp/otlpmetric/otlpmetrichttp package (adhering to the Golang's DefaultTransport from net/http).
// will use [http.ProxyFromEnvironment].
func WithProxy(pf oconf.HTTPTransportProxyFunc) Option {
return wrappedOption{oconf.WithProxy(pf)}
}
3 changes: 1 addition & 2 deletions exporters/otlp/otlptrace/otlptracehttp/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ func WithRetry(rc RetryConfig) Option {

// WithProxy sets the Proxy function the client will use to determine the
// proxy to use for an HTTP request. If this option is not used, the client
// will use the default proxy settings from the
// exporters/otlp/otlpmetric/otlptracehttp package (adhering to the Golang's DefaultTransport from net/http).
// will use [http.ProxyFromEnvironment].
func WithProxy(pf otlpconfig.HTTPTransportProxyFunc) Option {
return wrappedOption{otlpconfig.WithProxy(pf)}
}

0 comments on commit 26e48c4

Please sign in to comment.