-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keys() method to propagation.TextMapCarrier #1544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and propagation.HeaderCarrier to adapt http.Header to this interface.
punya
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
February 17, 2021 02:35
Codecov Report
@@ Coverage Diff @@
## main #1544 +/- ##
=======================================
- Coverage 78.0% 78.0% -0.1%
=======================================
Files 127 127
Lines 6590 6600 +10
=======================================
+ Hits 5146 5153 +7
- Misses 1200 1203 +3
Partials 244 244
|
Aneurysm9
approved these changes
Feb 17, 2021
XSAM
approved these changes
Feb 17, 2021
MrAlias
approved these changes
Feb 17, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
...and propagation.HeaderCarrier to adapt http.Header to this interface. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and propagation.HeaderCarrier to adapt http.Header to this interface.
Fixes #1493.