Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keys() method to propagation.TextMapCarrier #1544

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

punya
Copy link
Member

@punya punya commented Feb 17, 2021

...and propagation.HeaderCarrier to adapt http.Header to this interface.

Fixes #1493.

...and propagation.HeaderCarrier to adapt http.Header to this interface.
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1544 (1e94882) into main (0b1a1c7) will decrease coverage by 0.0%.
The diff coverage is 58.3%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1544     +/-   ##
=======================================
- Coverage   78.0%   78.0%   -0.1%     
=======================================
  Files        127     127             
  Lines       6590    6600     +10     
=======================================
+ Hits        5146    5153      +7     
- Misses      1200    1203      +3     
  Partials     244     244             
Impacted Files Coverage Δ
bridge/opentracing/bridge.go 47.8% <0.0%> (ø)
propagation/propagation.go 78.5% <40.0%> (-21.5%) ⬇️
oteltest/text_map_propagator.go 76.2% <100.0%> (+1.5%) ⬆️

@MrAlias MrAlias merged commit 3bce9c9 into open-telemetry:main Feb 17, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Mar 3, 2021
ldelossa pushed a commit to ldelossa/opentelemetry-go that referenced this pull request Mar 5, 2021
...and propagation.HeaderCarrier to adapt http.Header to this interface.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keys func to TextMapCarrier
5 participants