add code attributes to semconv package #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zidhuss
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
XSAM
approved these changes
Feb 19, 2021
Aneurysm9
approved these changes
Feb 19, 2021
zidhuss
force-pushed
the
semconv-code
branch
from
a3ac2e2 to
41eeaaa
Compare
MrAlias
approved these changes
Feb 22, 2021
Adds a full-stop at the end of the comment.
Codecov Report
@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
- Coverage 78.2% 78.0% -0.2%
=======================================
Files 127 127
Lines 6577 6597 +20
=======================================
+ Hits 5146 5151 +5
- Misses 1185 1201 +16
+ Partials 246 245 -1
|
MrAlias
approved these changes
Feb 22, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* add code attributes to semconv package * update changelog * update comment for code semconv attributes Adds a full-stop at the end of the comment. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the source code attributes introduced in open-telemetry/opentelemetry-specification#901 to the
semconvpackage.