Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape exemplar keys to fix invalid key errors #5995

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dashpole
Copy link
Contributor

Fixes #5936

@dashpole dashpole changed the title Sanitize exemplar keys to fix invalid key errors Escape exemplar keys to fix invalid key errors Nov 21, 2024
@dashpole dashpole added the bug Something isn't working label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (99c3c66) to head (5644ee0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5995     +/-   ##
=======================================
- Coverage   82.1%   82.1%   -0.1%     
=======================================
  Files        273     273             
  Lines      23615   23616      +1     
=======================================
  Hits       19400   19400             
- Misses      3870    3871      +1     
  Partials     345     345             

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@pellared pellared added this to the v1.33.0 milestone Nov 22, 2024
@pellared pellared added the pkg:exporter:prometheus Related to the Prometheus exporter package label Nov 22, 2024
@dashpole dashpole merged commit 2edaccb into open-telemetry:main Nov 22, 2024
36 checks passed
@dashpole dashpole deleted the fix_exemplar_sanitization branch November 22, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus - Exemplar label name is invalid when filtering attributes in a custom view
4 participants