fix: remove types of the instrumented libs form public apis (#1221)

* fix: remove types of the instrumented libs form public apis * fix: revert mongoose instrumentation utils.ts change Co-authored-by: Amir Blum <amir@aspecto.io>
open-telemetry · Oct 19, 2022 · 682d610 · 682d610
1 parent 6300733
commit 682d610
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plugins/node/instrumentation-dataloader/src/instrumentation.ts b/plugins/node/instrumentation-dataloader/src/instrumentation.ts
@@ -70,7 +70,8 @@ export class DataloaderInstrumentation extends InstrumentationBase {
             this._unwrap(dataloader.prototype, 'loadMany');
           }
         }
-      ),
+        // cast it to module definition of unknown type to avoid exposing Dataloader types on public APIs
+      ) as InstrumentationNodeModuleDefinition<unknown>,
     ];
   }
 

diff --git a/plugins/node/instrumentation-mongoose/src/mongoose.ts b/plugins/node/instrumentation-mongoose/src/mongoose.ts
@@ -84,7 +84,7 @@ export class MongooseInstrumentation extends InstrumentationBase<any> {
     return module;
   }
 
-  protected patch(
+  private patch(
     moduleExports: typeof mongoose,
     moduleVersion: string | undefined
   ) {
@@ -127,7 +127,7 @@ export class MongooseInstrumentation extends InstrumentationBase<any> {
     return moduleExports;
   }
 
-  protected unpatch(moduleExports: typeof mongoose): void {
+  private unpatch(moduleExports: typeof mongoose): void {
     this._diag.debug('mongoose instrumentation: unpatch mongoose');
     this._unwrap(moduleExports.Model.prototype, 'save');
     // revert the patch for $save which we applyed by aliasing it to patched `save`
-Original file line number
+Diff line change
@@ Expand Up @@
                 this._unwrap(dataloader.prototype, 'loadMany');
               }
             }
-          ),
+            // cast it to module definition of unknown type to avoid exposing Dataloader types on public APIs
+          ) as InstrumentationNodeModuleDefinition<unknown>,
         ];
       }
@@ Expand Down @@