[instrumentation-ioredis] failing tav tests for ioredis@5.8.0

[pichlermarc]

Tests are currently failing for ioredis@5.8.0, released yesterday

Logs indicate that telemetry is lost, but the library seems to continue to function normally:

2025-09-23T15:50:52.4092765Z -- required packages ["ioredis@5.8.0"]
2025-09-23T15:50:52.4093654Z -- installing ["ioredis@5.8.0"]
2025-09-23T15:50:58.6331889Z -- running test "npm run test" with ioredis (env: {})
2025-09-23T15:50:58.9928723Z 
2025-09-23T15:50:58.9929830Z > @opentelemetry/instrumentation-ioredis@0.53.1 test
2025-09-23T15:50:58.9930316Z > nyc --no-clean mocha 'test/**/*.test.ts'
2025-09-23T15:50:58.9930514Z 
2025-09-23T15:51:00.4596573Z 
2025-09-23T15:51:00.4596589Z 
2025-09-23T15:51:00.4605151Z   ioredis
2025-09-23T15:51:00.5038964Z     ✔ should have correct module name
2025-09-23T15:51:01.0690766Z     ✔ should work with ESM usage (564ms)
2025-09-23T15:51:01.0692676Z     #createClient()
2025-09-23T15:51:01.1001098Z       1) should propagate the current span to event handlers
2025-09-23T15:51:01.1017091Z     #send_internal_message()
2025-09-23T15:51:01.1038353Z       Instrumenting query operations
2025-09-23T15:51:01.1069364Z         ✔ should create a child span for cb style insert
2025-09-23T15:51:01.1105018Z         ✔ should create a child span for cb style get
2025-09-23T15:51:01.1130168Z         ✔ should create a child span for hset promise
2025-09-23T15:51:01.1177193Z         ✔ should set span with error when redis return reject
2025-09-23T15:51:01.1203603Z         ✔ should create a child span for streamify scanning
2025-09-23T15:51:01.1218895Z         - should create a child span for pubsub
2025-09-23T15:51:01.1242909Z         ✔ should create a child span for multi/transaction
2025-09-23T15:51:01.1266129Z         ✔ should create a child span for pipeline
2025-09-23T15:51:01.1286136Z         ✔ should create a child span for get promise
2025-09-23T15:51:01.1306831Z         ✔ should create a child span for del
2025-09-23T15:51:01.1331139Z         ✔ should create a child span for lua
2025-09-23T15:51:01.1341587Z       Instrumenting without parent span
2025-09-23T15:51:01.1351260Z         ✔ should not create child span for query
2025-09-23T15:51:01.1382902Z         ✔ should not create child span for connect
2025-09-23T15:51:01.1393125Z       Instrumentation with requireParentSpan
2025-09-23T15:51:01.1404179Z         ✔ should instrument queries with requireParentSpan equal false
2025-09-23T15:51:01.1414297Z         - should instrument connect with requireParentSpan equal false
2025-09-23T15:51:01.1424344Z         ✔ should not instrument queries with requireParentSpan equal true
2025-09-23T15:51:01.1452375Z         ✔ should not instrument connect with requireParentSpan equal true
2025-09-23T15:51:01.1462053Z       Instrumenting with a custom db.statement serializer
2025-09-23T15:51:01.1473753Z         ✔ should tag the span with a custom db.statement for cb style insert
2025-09-23T15:51:01.1490041Z         ✔ should tag the span with a custom db.statement for cb style get
2025-09-23T15:51:01.1501220Z       Removing instrumentation
2025-09-23T15:51:01.1511698Z         ✔ should not create a child span for cb style insert
2025-09-23T15:51:01.1526818Z         ✔ should not create a child span for cb style get
2025-09-23T15:51:01.1542606Z         ✔ should not create a child span for hset promise upon error
2025-09-23T15:51:01.1550439Z       Instrumenting with a custom hooks
2025-09-23T15:51:01.1578180Z         ✔ should call requestHook when set in config
2025-09-23T15:51:01.1598528Z         ✔ should ignore requestHook which throws exception
2025-09-23T15:51:01.1616959Z         ✔ should call responseHook when set in config
2025-09-23T15:51:01.1634885Z         ✔ should ignore responseHook which throws exception
2025-09-23T15:51:01.1643696Z       setConfig - custom dbStatementSerializer config
2025-09-23T15:51:01.1654533Z         ✔ should properly execute the db statement serializer for operation insert
2025-09-23T15:51:01.1672008Z         ✔ should properly execute the db statement serializer for operation get
2025-09-23T15:51:01.1686293Z 
2025-09-23T15:51:01.1690420Z 
2025-09-23T15:51:01.1692829Z   28 passing (710ms)
2025-09-23T15:51:01.1693342Z   2 pending
2025-09-23T15:51:01.1694058Z   1 failing
2025-09-23T15:51:01.1694239Z 
2025-09-23T15:51:01.1710027Z   1) ioredis
2025-09-23T15:51:01.1710431Z        #createClient()
2025-09-23T15:51:01.1711002Z          should propagate the current span to event handlers:
2025-09-23T15:51:01.1711398Z 
2025-09-23T15:51:01.1711924Z       Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
2025-09-23T15:51:01.1712492Z 
2025-09-23T15:51:01.1712638Z 5 !== 4
2025-09-23T15:51:01.1712803Z 
2025-09-23T15:51:01.1712970Z       + expected - actual
2025-09-23T15:51:01.1713250Z 
2025-09-23T15:51:01.1713576Z       -5
2025-09-23T15:51:01.1713896Z       +4
2025-09-23T15:51:01.1714151Z       
2025-09-23T15:51:01.1715222Z       at /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/packages/instrumentation-ioredis/test/ioredis.test.ts:158:18
2025-09-23T15:51:01.1717136Z       at tryCatcher (/home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/node_modules/standard-as-callback/built/utils.js:12:23)
2025-09-23T15:51:01.1718975Z       at /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/node_modules/standard-as-callback/built/index.js:22:53
2025-09-23T15:51:01.1720291Z       at processTicksAndRejections (node:internal/process/task_queues:95:5)
2025-09-23T15:51:01.1720811Z 
2025-09-23T15:51:01.1720821Z 
2025-09-23T15:51:01.1720830Z 
2025-09-23T15:51:01.2282649Z --------------------|---------|----------|---------|---------|---------------------------
2025-09-23T15:51:01.2284401Z File                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s         
2025-09-23T15:51:01.2285384Z --------------------|---------|----------|---------|---------|---------------------------
2025-09-23T15:51:01.2289395Z All files           |    91.2 |    70.83 |     100 |   92.13 |                           
2025-09-23T15:51:01.2292148Z  instrumentation.ts |   89.74 |    69.56 |     100 |    90.9 | 63,71,112,185-186,221-222 
2025-09-23T15:51:01.2294066Z  semconv.ts         |     100 |      100 |     100 |     100 |                           
2025-09-23T15:51:01.2295084Z  utils.ts           |     100 |      100 |     100 |     100 |                           
2025-09-23T15:51:01.2295899Z --------------------|---------|----------|---------|---------|---------------------------
2025-09-23T15:51:01.2398926Z npm ERR! Lifecycle script `test` failed with error: 
2025-09-23T15:51:01.2399632Z npm ERR! Error: command failed 
2025-09-23T15:51:01.2404399Z npm ERR!   in workspace: @opentelemetry/instrumentation-ioredis@0.53.1 
2025-09-23T15:51:01.2405903Z npm ERR!   at location: /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/packages/instrumentation-ioredis 
2025-09-23T15:51:01.2488002Z -- detected failing command, flushing stdout...
2025-09-23T15:51:01.2488385Z 
2025-09-23T15:51:01.2489752Z -- fatal: Test exited with code 1

[pichlermarc]

I was not able to find a test run with ioredis@5.7.0 - so maybe it's also affected by the same issue.

[pichlermarc]

Tested locally with ioredis@5.7.0 - this works, so it's likely only ioredis@5.8.0 that's the culprit.

[pichlermarc]

Looks like it actually has one too many spans instead of missing spans.

[pichlermarc]

Looks like there's an additional client span for client SETINFO LIB-NAME ioredis - that might be new.

[pichlermarc]

Aha, it's a new feature: redis/ioredis#2011.
I'll adapt the tests.

[pichlermarc]

Downgrading to P4 - everything is working as expected, except our tests. 😄