Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add renovate config for OTel core experimental #1246

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Oct 24, 2022

OTel core experimental packages require a manual update on each release because ^ ranges for 0.x versions only include new patch versions.

Add a separate renovate config for these packages.

OTel core experimental packages require a manual update on each release because ^ ranges for 0.x
versions only include new patch versions.

Add a separate renovate config for these packages.
@Flarna Flarna requested a review from a team October 24, 2022 10:50
@Flarna
Copy link
Member Author

Flarna commented Oct 24, 2022

Don't know if there is any way to test a renovate configuration. I added the new entry mostly based on guessing.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1246 (3573a09) into main (c7f08fe) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          14       14           
  Lines         893      893           
  Branches      191      191           
=======================================
  Hits          858      858           
  Misses         35       35           

@Flarna
Copy link
Member Author

Flarna commented Nov 2, 2022

@open-telemetry/javascript-maintainers How are the current rules regarding merging of PRs like this which is not within of a package having an owner?

@blumamir
Copy link
Member

blumamir commented Nov 2, 2022

@open-telemetry/javascript-maintainers How are the current rules regarding merging of PRs like this which is not within of a package having an owner?

I don't think we have rules for that.
It's been open long enough for anyone interested in reviewing it to add comments.

Let's merge when CI is green

@blumamir blumamir merged commit 6667853 into open-telemetry:main Nov 2, 2022
@Flarna Flarna deleted the renovate branch November 2, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants