-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: amqplib instrumentation #892
Conversation
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 95.91% 94.87% -1.04%
==========================================
Files 13 17 +4
Lines 856 1230 +374
Branches 178 267 +89
==========================================
+ Hits 821 1167 +346
- Misses 35 63 +28
|
Thanks @Flarna , that is a great review. Learned a few new things, very appreciated. |
@Flarna Thanks again for the review. If I am not mistaken, everything is resolved |
@blumamir I got interrupted a few times during review. Left two more comments, nothing blocking. I have to admit that I didn't follow the amqplib patching details as I'm not familiar with this library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm (i'm no amplib expert though), i think you'll need to update the release please config as daniel did there though #921
done 👍 |
I will keep this PR open for another week, giving anyone who wishes to review the chance to do it. |
Oops, sorry about that. Checking what happened |
PR to fix the daily tests in CI: #946 |
This is an instrumentation library for the amqplib package which is used for RabbitMQ.
It exists for a year and is currently hosted in ext-js repo, been used and working in production environments, and has 6.4K weekly downloads from npm.
The code is ported as-is with few changes to the hooks signatures.