From 41235a9e68b13050ad49b8d6abc5c868885a74fe Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Tue, 2 Mar 2021 15:26:18 +0200 Subject: [PATCH] feat(semantic-conventions): add missing RpcAttributes from spec (#1976) Co-authored-by: Daniel Dyla --- .../src/trace/rpc.ts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/packages/opentelemetry-semantic-conventions/src/trace/rpc.ts b/packages/opentelemetry-semantic-conventions/src/trace/rpc.ts index c2681b3d98..ec23d93bf3 100644 --- a/packages/opentelemetry-semantic-conventions/src/trace/rpc.ts +++ b/packages/opentelemetry-semantic-conventions/src/trace/rpc.ts @@ -14,8 +14,30 @@ * limitations under the License. */ export const RpcAttribute = { + /** + * A string identifying the remoting system. + * + * @remarks + * Required + */ + RPC_SYSTEM: 'rpc.system', + + /** + * The full name of the service being called, including its package name, if applicable. + * + * @remarks + * Not required, but recommended + */ RPC_SERVICE: 'rpc.service', + /** + * The name of the method being called, must be equal to the $method part in the span name. + * + * @remarks + * Not required, but recommended + */ + RPC_METHOD: 'rpc.method', + // GRPC (no spec) GRPC_KIND: 'grpc.kind', // SERVER or CLIENT GRPC_METHOD: 'grpc.method',