fix(otlp-exporter-base): improve fetch error handling.

open-telemetry · Jan 28, 2023 · 7a36740 · 7a36740
1 parent a0aa0c9
commit 7a36740
Showing 1 changed file with 26 additions and 22 deletions.
diff --git a/experimental/packages/otlp-exporter-base/src/platform/browser/util.ts b/experimental/packages/otlp-exporter-base/src/platform/browser/util.ts
@@ -130,28 +130,32 @@ export function sendWithFetch(
     signal: controller.signal,
     body,
   })
-    .then(response => {
-      if (response.ok) {
-        response.text().then(
-          t => diag.debug('Request Success', t),
-          () => {}
-        );
-        onSuccess();
-      } else {
-        onError(
-          new OTLPExporterError(
-            `Failed to export with fetch: (${response.status} ${response.statusText})`,
-            response.status
-          )
-        );
-      }
-    })
-    .catch((e: Error) => {
-      if (e.name === 'AbortError') {
-        onError(new OTLPExporterError('Request Timeout'));
-      } else {
-        onError(new OTLPExporterError(`Request Fail: ${e.name} ${e.message}`));
+    .then(
+      response => {
+        if (response.ok) {
+          response.text().then(
+            t => diag.debug('Request Success', t),
+            () => {}
+          );
+          onSuccess();
+        } else {
+          onError(
+            new OTLPExporterError(
+              `Failed to export with fetch: (${response.status} ${response.statusText})`,
+              response.status
+            )
+          );
+        }
+      },
+      (e: Error) => {
+        if (e.name === 'AbortError') {
+          onError(new OTLPExporterError('Request Timeout'));
+        } else {
+          onError(
+            new OTLPExporterError(`Request Fail: ${e.name} ${e.message}`)
+          );
+        }
       }
-    })
+    )
     .finally(() => clearTimeout(timerId));
 }