Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv(tests): add e2e test with collector for all of our OTLP exporters #2157

Open
vmarchaud opened this issue Apr 25, 2021 · 3 comments
Open
Labels
blocked Currently blocked on another item needs:code-contribution This feature/bug is ready to implement never-stale type:feature A feature with no sub-issues to address

Comments

@vmarchaud
Copy link
Member

After changing the default port I can assume it will not be working. Could you please update the docker to ensure it is still working fine (use the latest docker image 0.25)?

Sure, but i think it would make sense to make test with the collector (end to end pretty much) itself in our pipeline so this doesn't require manual testing in the future

Originally posted by @vmarchaud in #2117 (comment)

@vmarchaud vmarchaud added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 25, 2021
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jun 20, 2022
@pichlermarc pichlermarc added type:feature A feature with no sub-issues to address needs:code-contribution This feature/bug is ready to implement labels Oct 17, 2023
@pichlermarc pichlermarc added this to the OTLP Exporter GA milestone Oct 17, 2023
@JamieDanielson
Copy link
Member

We've had some success using jq and bats for testing our distros at Honeycomb, and also added it to the opentelemetry-go-instrumentation project. Wonder if there is appetite to have the same thing here?

Basically we spin up an app and a collector in docker, export to a file, and make assertions on the output. I wrote a bit of detail here on a small blog post, and here is an example test in our JS distro. I would be happy to help with this effort if it seems like a reasonable path forward.

@pichlermarc pichlermarc changed the title improv(tests): add e2e test with collector for all of our collector exporters improv(tests): add e2e test with collector for all of our OTLP exporters Oct 15, 2024
@pichlermarc pichlermarc added blocked Currently blocked on another item and removed up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 15, 2024
@pichlermarc
Copy link
Member

@JamieDanielson this sounds like a great idea 🙂

I'm adding the blocked label as I'm currently modifying some of the existing tests and I want to ensure that nobody is working on this (this will likely lead to conflicts). I still think that we should do this, tough (ideally before releasing a GA version of the OTLP exporters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Currently blocked on another item needs:code-contribution This feature/bug is ready to implement never-stale type:feature A feature with no sub-issues to address
Projects
None yet
Development

No branches or pull requests

3 participants