Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful message when instrumentation fails #3051

Closed
weyert opened this issue Jun 19, 2022 · 5 comments
Closed

Unhelpful message when instrumentation fails #3051

weyert opened this issue Jun 19, 2022 · 5 comments

Comments

@weyert
Copy link
Contributor

weyert commented Jun 19, 2022

Is your feature request related to a problem? Please describe.

When you try to activate instrumentation but the instrumentation doesn't support your version of the package you get a unhelpful message similar to No modules instrumentation has been defined, nothing will be patched. The current message doesn't tell which instrumentation is patching modules. Making it less easy to resolve the problem

Describe the solution you'd like

I would like to propose to include the name of the instrumentation in the message

Describe alternatives you've considered

I have considered not solving this issue

Additional context

I was trying to instrument a third party package but the instrumentation only supported older version of the package

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as completed Sep 5, 2022
@mikeldking
Copy link

Bump on this. Hitting this issue after migrating to the latest. Any help on what this error means would be greatly appreciated

@nickleach
Copy link

Yes same. Any guidance would be helpful

@legendecas
Copy link
Member

This should have been fixed by #3308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants