Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry Collector exporter for web #499

Closed
mayurkale22 opened this issue Nov 6, 2019 · 5 comments · Fixed by #552
Closed

Add OpenTelemetry Collector exporter for web #499

mayurkale22 opened this issue Nov 6, 2019 · 5 comments · Fixed by #552
Assignees
Milestone

Comments

@mayurkale22
Copy link
Member

Add OpenTelemetry Collector (aka "agent") exporter for Web SDK. The OpenTelemetry Collector can receive traces and metrics from processes instrumented by OpenTelemetry and exports traces and metrics to one or more monitoring/tracing backends. One of the advantage of this approach is that you don't have to write all exporters in native language.

The best reference architecture would be Browser > OpenTelemetry Collector Exporter > OpenTelemetry Collector > Destination(s)

Reference code: https://github.com/census-instrumentation/opencensus-web/tree/master/packages/opencensus-web-exporter-ocagent

@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 6, 2019
@mayurkale22
Copy link
Member Author

/cc @draffensperger @obecny

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 6, 2019
@mayurkale22
Copy link
Member Author

Please suggest name for the package. One suggestion: opentelemetry-exporter-web-collector

opentelemetry-exporter-* is matching with other exporters name pattern, web is to indicate that this is meant for browser and collector is the backend name similat to zipkin/jaeger.

@obecny
Copy link
Member

obecny commented Nov 7, 2019

opentelemetry-exporter-web-collector sounds most reasonable for me

@draffensperger
Copy link
Contributor

I agree with opentelemetry-exporter-web-collector, though if it ends up that there can be a lot of shared code between Node and web here then having a single opentelemetry-exporter-collector might make sense - but let's start with two separate packages.

@obecny
Copy link
Member

obecny commented Nov 20, 2019

it appeared to be easier to create web and node at the same time. I named this as
opentelemetry-exporter-collector and class CollectorExporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants