From ce7dfb12ef3442ebb90e1ae7c44470a2b06e514c Mon Sep 17 00:00:00 2001 From: Herman Date: Fri, 27 Aug 2021 17:02:42 +0200 Subject: [PATCH] Fix ReferenceError When OTEL_TRACES_SAMPLER is used without OTEL_TRACES_SAMPLER_ARG there would be a ReferenceError due to getSamplerProbabilityFromEnv being called above the definition of DEFAULT_RATIO. ``` ReferenceError: Cannot access 'DEFAULT_RATIO' before initialization at null.getSamplerProbabilityFromEnv (/app/node_modules/@opentelemetry/tracing/src/config.ts:91:58) at null.buildSamplerFromEnv (/app/node_modules/@opentelemetry/tracing/src/config.ts:71:44) at Object. (/app/node_modules/@opentelemetry/tracing/src/config.ts:38:12) at Module._compile (internal/modules/cjs/loader.js:1085:14) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10) at Module.load (internal/modules/cjs/loader.js:950:32) at Function.Module._load (internal/modules/cjs/loader.js:784:16) at Module.require (internal/modules/cjs/loader.js:974:19) at require (internal/modules/cjs/helpers.js:92:18) at Object. (/app/node_modules/@opentelemetry/tracing/src/utility.ts:17:1)``` --- packages/opentelemetry-sdk-trace-base/src/config.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/opentelemetry-sdk-trace-base/src/config.ts b/packages/opentelemetry-sdk-trace-base/src/config.ts index 38c869cfa7..042427d04a 100644 --- a/packages/opentelemetry-sdk-trace-base/src/config.ts +++ b/packages/opentelemetry-sdk-trace-base/src/config.ts @@ -27,6 +27,7 @@ import { const env = getEnv(); const FALLBACK_OTEL_TRACES_SAMPLER = TracesSamplerValues.AlwaysOn; +const DEFAULT_RATIO = 1; /** * Default configuration. For fields with primitive values, any user-provided @@ -79,8 +80,6 @@ export function buildSamplerFromEnv( } } -const DEFAULT_RATIO = 1; - function getSamplerProbabilityFromEnv( env: Required ): number | undefined {