From 8e44c108d2dba66b01da06b860e6cb8d831c1182 Mon Sep 17 00:00:00 2001 From: "marc.pichler" Date: Fri, 29 Apr 2022 14:22:17 +0200 Subject: [PATCH] fixup! --- .../src/platform/node/instrumentation.ts | 2 +- .../packages/opentelemetry-sdk-node/test/sdk.test.ts | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts b/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts index 09d6a86b292..f2dcedcc247 100644 --- a/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts +++ b/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts @@ -59,7 +59,7 @@ export abstract class InstrumentationBase } } - private _warnOnPreloadedModules(): void { + protected _warnOnPreloadedModules(): void { this._modules.forEach((module: InstrumentationModuleDefinition) => { const { name } = module; try { diff --git a/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts b/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts index 2237828534f..be7760b8aff 100644 --- a/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts +++ b/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts @@ -363,11 +363,16 @@ describe('Node SDK', () => { // This test depends on the env detector to be functioning as intended const mockedLoggerMethod = Sinon.fake(); const mockedVerboseLoggerMethod = Sinon.fake(); + const nop = () => { + }; diag.setLogger( { debug: mockedLoggerMethod, verbose: mockedVerboseLoggerMethod, - } as any, + warn: nop, + error: nop, + info: nop + }, DiagLogLevel.VERBOSE );