diff --git a/CHANGELOG.md b/CHANGELOG.md index d6e31bc077..6ca803912a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/ ### :books: (Refine Doc) * refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic +* refactor(examples): use new exported string constants for semconv in examples/opentracing-shim-semconv [#4761](https://github.com/open-telemetry/opentelemetry-js/pull/4761) @Zen-cronic ### :house: (Internal) diff --git a/examples/opentracing-shim/package.json b/examples/opentracing-shim/package.json index 37cc5ab31d..598c9b4762 100644 --- a/examples/opentracing-shim/package.json +++ b/examples/opentracing-shim/package.json @@ -36,7 +36,7 @@ "@opentelemetry/instrumentation": "0.25.0", "@opentelemetry/sdk-trace-node": "0.25.0", "@opentelemetry/resources": "0.25.0", - "@opentelemetry/semantic-conventions": "0.25.0", + "@opentelemetry/semantic-conventions": "^1.22.0", "@opentelemetry/shim-opentracing": "0.25.0", "@opentelemetry/sdk-trace-base": "0.25.0", "opentracing": "^0.14.4" diff --git a/examples/opentracing-shim/shim.js b/examples/opentracing-shim/shim.js index fe6771ced4..0f791071ee 100644 --- a/examples/opentracing-shim/shim.js +++ b/examples/opentracing-shim/shim.js @@ -1,6 +1,6 @@ 'use strict'; -const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions'); +const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions'); const { Resource } = require('@opentelemetry/resources'); const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node'); const { SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base'); @@ -10,7 +10,7 @@ const { TracerShim } = require('@opentelemetry/shim-opentracing'); function shim(serviceName) { const provider = new NodeTracerProvider({ - resource: new Resource({ [SemanticResourceAttributes.SERVICE_NAME]: serviceName }), + resource: new Resource({ [SEMRESATTRS_SERVICE_NAME]: serviceName }), }); provider.addSpanProcessor(new SimpleSpanProcessor(getExporter(serviceName)));