From a6bd7c1fc0068e600bf16788bee7f7a28a655657 Mon Sep 17 00:00:00 2001 From: omarHassane Date: Mon, 11 Nov 2024 16:51:39 -0500 Subject: [PATCH 1/2] fix: iterating through the OTEL_SEMCONV_STABILITY_OPT_IN content instead of the entry indices --- .../packages/opentelemetry-instrumentation-http/src/http.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimental/packages/opentelemetry-instrumentation-http/src/http.ts b/experimental/packages/opentelemetry-instrumentation-http/src/http.ts index f7672440cf..cd38055a4e 100644 --- a/experimental/packages/opentelemetry-instrumentation-http/src/http.ts +++ b/experimental/packages/opentelemetry-instrumentation-http/src/http.ts @@ -109,7 +109,7 @@ export class HttpInstrumentation extends InstrumentationBase Date: Mon, 11 Nov 2024 17:43:28 -0500 Subject: [PATCH 2/2] fix: changelog --- experimental/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 55c5d66a4f..62ec3f61c7 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -50,6 +50,8 @@ All notable changes to experimental packages in this project will be documented ### :bug: (Bug Fix) +* fix(instrumentation-http): Fix the `OTEL_SEMCONV_STABILITY_OPT_IN` variable check. Using `of` instead of `in` [#5137](https://github.com/open-telemetry/opentelemetry-js/pull/5137) + * fix(instrumentation-http): drop url.parse in favor of URL constructor [#5091](https://github.com/open-telemetry/opentelemetry-js/pull/5091) @pichlermarc * fixes a bug where using cyrillic characters in a client request string URL would throw an exception, whereas an un-instrumented client would accept the same input without throwing an exception